Reject rounds=0 for SHA1 hashes #677
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
samtstern reviewed Oct 18, 2019
| }); | ||
| }); | ||
| | ||
| md5ShaPbkdfAlgorithms.forEach((algorithm) => { |
Contributor
There was a problem hiding this comment.
This is an amazing variable name.
samtstern approved these changes Oct 18, 2019
hiranya911 approved these changes Oct 18, 2019
bojeil-google approved these changes Oct 23, 2019
Contributor
bojeil-google left a comment
bojeil-google left a comment There was a problem hiding this comment.
Thanks for the fix. Looks good. Just one typo.
| maxRounds = 120000; | ||
| break; | ||
| default: | ||
| throw new Error('Unexpected algorith: ' + algorithm); |
rsgowman added a commit to firebase/firebase-admin-java that referenced this pull request Nov 1, 2019
rsgowman added a commit to firebase/firebase-admin-go that referenced this pull request Nov 1, 2019
rsgowman added a commit to firebase/firebase-admin-python that referenced this pull request Nov 1, 2019
rsgowman added a commit to firebase/firebase-admin-java that referenced this pull request Nov 5, 2019
rsgowman added a commit to firebase/firebase-admin-python that referenced this pull request Nov 5, 2019
rsgowman added a commit to firebase/firebase-admin-go that referenced this pull request Nov 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Port of firebase/firebase-tools#1701