feat(fdc): Data Connect Bulk Import #2905
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Refactors the previously added DataConnect CRUD helper methods (`insert`, `insertMany`, `upsert`, `upsertMany`) based on feedback. The core implementation logic (input validation, data serialization using `objectToString`, GraphQL mutation string construction, and calling `executeGraphql`) has been moved from the `DataConnect` class (`data-connect.ts`) to the `DataConnectApiClient` class (`data-connect-api-client-internal.ts`). The methods in the `DataConnect` class now act as simple pass-through delegates to the corresponding methods on the internal client instance. Unit tests have been updated accordingly: - Tests in `index.spec.ts` now verify the delegation from `DataConnect` to `DataConnectApiClient`. - New tests have been added to `data-connect-api-client-internal.spec.ts` to cover the implementation details within `DataConnectApiClient`. This change improves separation of concerns, keeping the public API surface (`DataConnect`) clean and concentrating the implementation details within the internal client.
lahirumaramba changed the title lahirumaramba changed the title ![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
test/unit/data-connect/data-connect-api-client-internal.spec.ts Dismissed Show dismissed Hide dismissed
maneesht reviewed May 7, 2025
test/unit/data-connect/data-connect-api-client-internal.spec.ts Outdated Show resolved Hide resolved
markarndt approved these changes May 7, 2025
maneesht reviewed May 7, 2025
lahirumaramba force-pushed the refactor-data-connect-crud-impl branch from fe5f681 to ecd2915 Compare This reverts commit ecd2915.
maneesht approved these changes May 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Add new API interfaces for
insert,insertMany,upsert,upsertManyoperations.