feat(rc): Add Remote Config Parameter Value Type support #591
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
lahirumaramba force-pushed the lm-rc-param-valuetype branch from 3c37bde to 896c9fa Compare 
lahirumaramba force-pushed the lm-rc-param-valuetype branch from 896c9fa to 63d2de2 Compare 
hiranya911 approved these changes Sep 17, 2021
| assertNotEquals(parameterOne, parameterFive); | ||
| assertNotEquals(parameterOne, parameterSeven); | ||
| assertNotEquals(parameterThree, parameterFive); | ||
| assertNotEquals(parameterThree, parameterSeven); |
There was a problem hiding this comment.
May be also test for Equals() with parameter value types?
There was a problem hiding this comment.
Line 100 has an assertEquals() for parameter value types. Would that work?
| .setDefaultValue(ParameterValue.inAppDefault()) | ||
| .setDescription("greeting text") | ||
| .setConditionalValues(CONDITIONAL_VALUES) | ||
| .setValueType(ParameterValueType.STRING) |
There was a problem hiding this comment.
Do we have coverage here for parameters without types?
There was a problem hiding this comment.
Good call. Updated to have a parameter without a type.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
go/admin-sdk-rc-parameter-value-types
Add RC Parameter Value Type.
Update unit tests.
- Integration tests will be added following the REST API launch.- Addedrelease:stageto trigger existing integration tests (to test backward compatibility).-Do not mergeuntil the BE is updated.Update integration tests.
RELEASE NOTE: Added Remote Config Parameter Value Type Support.