fix: Using AuthorizedHttpClient for updating rules during tests #590
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Our nightly builds intermittently fail due to the race conditions outlined in googleapis/google-auth-library-java#692. As a possible fix I'd like to try setting the auth token in the request header instead of the URL. This way we do not have to directly interact with
GoogleCredentialsor auth tokens at all (which seems to be the source of the race condition). Instead we can get theHttpRequestFactoryAPI to handle all that internally, just like our service client implementations do.At the same time, I'm also refactoring the
IntegrationTestUtils.AppHttpClientclass into a top-levelRulesClientclass, and reducing its visibility to the database integration tests package.