Skip to content

fix(auth): adds missing EMAIL_NOT_FOUND error code #546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 3, 2021
Merged

fix(auth): adds missing EMAIL_NOT_FOUND error code #546

merged 3 commits into from
May 3, 2021

Conversation

bojeil-google
Copy link
Contributor

Catch EMAIL_NOT_FOUND when /accounts:sendOobCode is called for password reset on a user that does not exist.
@bojeil-google
fix(auth): adds missing EMAIL_NOT_FOUND error code
45a29a9 
Catch EMAIL_NOT_FOUND when /accounts:sendOobCode is called for password reset on a user that does not exist.
@bojeil-google bojeil-google requested a review from hiranya911 May 3, 2021 20:47
hiranya911
hiranya911 approved these changes May 3, 2021
View reviewed changes
Copy link
Contributor

@hiranya911 hiranya911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Should we add a test case? Something similar to:

firebase-admin-java/src/test/java/com/google/firebase/auth/FirebaseUserManagerTest.java

Line 2771 in 7352a43

public void testDeleteSamlProviderConfigWithNotFoundError() {

@bojeil-google
Copy link
Contributor Author

LGTM 👍

Should we add a test case? Something similar to:

firebase-admin-java/src/test/java/com/google/firebase/auth/FirebaseUserManagerTest.java

Line 2771 in 7352a43

public void testDeleteSamlProviderConfigWithNotFoundError() {

Done
@bojeil-google bojeil-google merged commit 104ab0d into master May 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-note

2 participants

@bojeil-google @hiranya911