Skip to content

Conversation

lahirumaramba
Copy link
Member

  • Add nightly build workflow.
  • Add a failing test to trigger the email notifications.

Note: Adding release:stage label to trigger integration tests. Integration tests should fail in this PR.

@lahirumaramba lahirumaramba added the release:stage Stage a release candidate label Apr 8, 2021
@lahirumaramba lahirumaramba requested a review from hiranya911 April 8, 2021 19:59
api-key: ${{ secrets.OSS_BOT_MAILGUN_KEY }}
domain: ${{ secrets.OSS_BOT_MAILGUN_DOMAIN }}
from: 'GitHub <admin-github@${{ secrets.OSS_BOT_MAILGUN_DOMAIN }}>'
to: ${{ secrets.FIREBASE_ADMIN_GITHUB_EMAIL }}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hiranya911 Is this an organization level secret?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not. I will add it to this repo shortly.

Copy link
Contributor

@hiranya911 hiranya911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@lahirumaramba lahirumaramba merged commit baa94fc into master Apr 20, 2021
@lahirumaramba lahirumaramba deleted the lm-add-nightly branch April 20, 2021 19:21
lahirumaramba added a commit that referenced this pull request Apr 20, 2021
- Remove the failing integration test added in #524 to test the nightly email notifications Note: staging to trigger integration tests. All tests should pass.
lahirumaramba added a commit that referenced this pull request Apr 21, 2021
* Remove the failing integration test - Remove the failing integration test added in #524 to test the nightly email notifications * Comment out SHA1 tests until a fix is ready
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release:stage Stage a release candidate

2 participants