Add Remote Config Pubish, Validate, and GetTemplateAtVersion operations #496
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
lahirumaramba force-pushed the lm-rc-publish branch from 5750833 to 2611e9e Compare 
lahirumaramba force-pushed the lm-rc-publish branch from 2611e9e to c63daf2 Compare 
hiranya911 suggested changes Nov 23, 2020
src/main/java/com/google/firebase/remoteconfig/FirebaseRemoteConfig.java Show resolved Hide resolved
src/test/java/com/google/firebase/remoteconfig/FirebaseRemoteConfigClientImplTest.java Outdated Show resolved Hide resolved
| } | ||
| | ||
| @Test(expected = IllegalStateException.class) | ||
| public void testGetTemplateAtVersionWithInvalidEtags() throws FirebaseRemoteConfigException { |
There was a problem hiding this comment.
Which line is supposed to throw in this test case?
There was a problem hiding this comment.
Good catch! It should throw on client.getTemplateAtVersion("24");. Converted into to two separate tests.
src/test/java/com/google/firebase/remoteconfig/FirebaseRemoteConfigClientImplTest.java Show resolved Hide resolved
hiranya911 approved these changes Nov 24, 2020
| @@ -0,0 +1,33 @@ | |||
| package com.google.firebase.remoteconfig.internal; | |||
There was a problem hiding this comment.
This can probably live in the parent package as a package-protected class.
There was a problem hiding this comment.
Good call! Moved to the parent class and made package protected, including the ctor. Thanks!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
getTemplateAtVersion(),publishTemplate(),validateTemplate(), andforcePublishTemplate()operations.Related to: #446