Skip to content

feat(fcm): Add image in notification support. #298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 27, 2019
Merged

feat(fcm): Add image in notification support. #298

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e6080d3
Add image in notification support.
chong-shao Aug 5, 2019
f141157
Fix indentation
chong-shao Aug 8, 2019
3ee631e
change param name from image to imageUrl
chong-shao Aug 14, 2019
048133d
Fix minor issues
chong-shao Aug 27, 2019
4a03645
fix tests
chong-shao Aug 27, 2019
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
change param name from image to imageUrl
  • Loading branch information
@chong-shao
chong-shao committed Aug 14, 2019
commit 3ee631eb22c0dcb808c86d4e0fc01eb9b7093ea0
8 changes: 4 additions & 4 deletions src/main/java/com/google/firebase/messaging/AndroidNotification.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -299,13 +299,13 @@ public Builder setChannelId(String channelId) {

/**
* Sets the URL of the image that is going to be displayed in the notification. When provided,
* overrides the image set via {@link Notification}.
* overrides the imageUrl set via {@link Notification}.
*
* @param image URL of the image that is going to be displayed in the notification.
* @param imageUrl URL of the image that is going to be displayed in the notification.
* @return This builder.
*/
public Builder setImage(String image) {
this.image = image;
public Builder setImage(String imageUrl) {
this.image = imageUrl;
return this;
}

Expand Down
6 changes: 3 additions & 3 deletions src/main/java/com/google/firebase/messaging/ApnsFcmOptions.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,11 +71,11 @@ public Builder setAnalyticsLabel(String analyticsLabel) {
}

/**
* @param image URL of the image that is going to be displayed in the notification.
* @param imageUrl URL of the image that is going to be displayed in the notification.
* @return This builder
*/
public Builder setImage(String image) {
this.image = image;
public Builder setImage(String imageUrl) {
this.image = imageUrl;
return this;
}

Expand Down
6 changes: 3 additions & 3 deletions src/main/java/com/google/firebase/messaging/Notification.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,12 +50,12 @@ public Notification(String title, String body) {
*
* @param title Title of the notification.
* @param body Body of the notification.
* @param image URL of the image that is going to be displayed in the notification.
* @param imageUrl URL of the image that is going to be displayed in the notification.
*/
public Notification(String title, String body, String image) {
public Notification(String title, String body, String imageUrl) {
this.title = title;
this.body = body;
this.image = image;
this.image = imageUrl;
}

}