fix: Email link sign-in #2263
Merged
fix: Email link sign-in #2263
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…baseUI-Android into feat/fix-email-link
Lyokone approved these changes Oct 28, 2025
| class InvalidEmailLinkException( | ||
| cause: Throwable? = null | ||
| ) : AuthException("You are are attempting to sign in with an invalid email link", cause) | ||
| ) : AuthException("", cause) |
Contributor
There was a problem hiding this comment.
Why are we removing the text reason for everything in this file?
Member Author
There was a problem hiding this comment.
I didn't want to duplicate what already existed in the stringProvider and since ErrorRecoveryDialog handled it, I could put them back too.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
No description provided.