-
- Notifications
You must be signed in to change notification settings - Fork 2.6k
Code Quality: Improved app startup routine 2 #12951
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| @d2dyno1 what's the plan for this PR? |
| I'm going to continue work on it this Thursday 🙂 |
| Ready for review! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! in terms of codebase quality.
I understand as follows
- Update app UI thread initialization stage
- Rename ImageModel to Image
- Add a service for pinning/unpinning
- System.IO to SystemIO (FYI, I introduced this simpified namespace alias to see all reference to that namespace because this namespace reference in storage class is not favorable)
| This appears to prevent launch from a cached instance from working. When I try to launch the app again, the window does not appear. |
| Should we revert? |
| Before we revert, I first want to figure out how to make launching from the cached instance work again. |
| Hmmm, even when I get the window to show up, the tabs don't show up properly or the app crashes. |
Resolved / Related Issues
Closes #issue...
Validation
How did you test these changes?