Fixed issue 2052 #2053
Merged
Fixed issue 2052 #2053
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Both of these had to be made together to pass our tests 1. always pass absolute url to json-schema-ref-parser 2. update json-schema-ref-parser to v11.1.0
| Tests do pass, however, Circle CI workflow should probably be updated to run tests on multiple platforms, not just linux |
| Thanks! For anyone looking to try this out, we've merged this pull request in @nicolas-chaulet/openapi-typescript-codegen, would love your feedback! |
| Having exactly this issue, hopefully this can be merged soon! |
Use the fork above in the mean time. It has multiple issues already fixed and some extra features. |
| Can confirm it works on Windows. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Both of these had to be made together to pass our tests
Should fix: #2052