Added completion support to type hinted local variables. #701
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| $declarationNode = | ||
| ParserHelpers\tryGetPropertyDeclaration($expr) ?? | ||
| ParserHelpers\tryGetConstOrClassConstDeclaration($expr); | ||
| $declarationNode = $declarationNode ?? $expr; |
There was a problem hiding this comment.
The double assignments reads very weird - just chain the ?? together
$declarationNode = ParserHelpers\tryGetPropertyDeclaration($expr) ?? ParserHelpers\tryGetConstOrClassConstDeclaration($expr) ?? $expr;
| Could you add a unit test for this? Otherwise it's prone to break through future changes |
Codecov Report
@@ Coverage Diff @@ ## master #701 +/- ## ============================================ + Coverage 82.17% 82.18% +0.01% - Complexity 935 938 +3 ============================================ Files 44 44 Lines 2154 2161 +7 ============================================ + Hits 1770 1776 +6 - Misses 384 385 +1
|
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Closes #350