fix(indexing): properly resolve self, static and parent keywords #532
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Previously we would dump static, self and parent as literal FQNs into the index.
Codecov Report
@@ Coverage Diff @@ ## master #532 +/- ## =========================================== - Coverage 79.25% 78.96% -0.3% - Complexity 814 832 +18 =========================================== Files 56 56 Lines 1938 1968 +30 =========================================== + Hits 1536 1554 +18 - Misses 402 414 +12
|
RenovZ pushed a commit to RenovZ/php-language-server that referenced this pull request Mar 25, 2022
…ixfbecker#532) Previously we would dump static, self and parent as literal FQNs into the index.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Previously we would dump static, self and parent as literal FQNs into the index.