fix(completion): don't suggest <?php on > characer #527
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| Awesome! :) |
felixfbecker force-pushed the no-html-completion branch from 697a7ce to 3cf3401 Compare 
Codecov Report
@@ Coverage Diff @@ ## master #527 +/- ## ============================================ + Coverage 79.13% 79.25% +0.11% - Complexity 810 814 +4 ============================================ Files 55 56 +1 Lines 1927 1938 +11 ============================================ + Hits 1525 1536 +11 Misses 402 402
|
This was referenced Nov 15, 2017
Closed
| This is still happening on my end. I have the latest version. Even tried uninstalling and reinstalling the extension. Here are my extensions: Here's a .gif: Anyone have any ideas? On Windows 7, btw. |
| It's probably not released in VS Code yet. |
RenovZ pushed a commit to RenovZ/php-language-server that referenced this pull request Mar 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
closes #372