fix(update): Ensure that the CLI binary will be executable after an update #1244
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…pdate When the downloaded CLI binary cannot be 'moved' into position (i.e. when it is located on a different filesystem from the target location), it is copied, but the permissions need to be set after the copy so that it will be executable. Closes fastly#1168.
Integralist approved these changes Jul 9, 2024
Collaborator
Integralist left a comment
Integralist left a comment There was a problem hiding this comment.
One minor comment, otherwise LGTM
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
When the downloaded CLI binary cannot be 'moved' into position (i.e. when it is located on a different filesystem from the target location), it is copied, but the permissions need to be set after the copy so that it will be executable.
Closes #1168.