Skip to content

fix(index): return undefined on error instead of null #133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 9, 2025
Merged

fix(index): return undefined on error instead of null #133

merged 1 commit into from
Mar 9, 2025

Conversation

Fdawgs
Copy link
Member

@Fdawgs Fdawgs commented Mar 6, 2025 •
edited
Loading

closes #132

This is a breaking change so it'd be great to combine this with #72

Checklist
@Fdawgs Fdawgs requested a review from a team March 8, 2025 12:01
gurgunday
gurgunday reviewed Mar 8, 2025
View reviewed changes
gurgunday

This comment was marked as outdated.

Sign in to view

gurgunday
gurgunday approved these changes Mar 8, 2025
View reviewed changes
Copy link
Member

@gurgunday gurgunday left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I see, makes sense to me as null is valid JSON
@gurgunday gurgunday requested review from a team and Uzlopak March 8, 2025 15:38
@Fdawgs Fdawgs merged commit adcf3eb into main Mar 9, 2025
18 checks passed
@Fdawgs Fdawgs deleted the fix/error-response branch March 9, 2025 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants

@Fdawgs @metcoder95 @Eomm @gurgunday