Skip to content

Conversation

gurgunday
Copy link
Member

No description provided.

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no need to drop old nodes for this

@gurgunday
Copy link
Member Author

gurgunday commented Apr 16, 2024

We just add pre-commit here now

We can close the PR or just merge to master

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina
Copy link
Member

why target next? This can land in main

@gurgunday gurgunday changed the base branch from next to master April 16, 2024 21:15
@gurgunday
Copy link
Member Author

gurgunday commented Apr 16, 2024

I might try to migrate to tap or node:test before merging

@gurgunday gurgunday marked this pull request as draft April 16, 2024 21:16
@gurgunday gurgunday marked this pull request as ready for review April 17, 2024 10:56
@mcollina mcollina merged commit 06c47de into fastify:master Apr 22, 2024
@gurgunday gurgunday deleted the v5 branch July 6, 2024 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants