🐛 Ensure that the default rich_markup_mode is interpreted correctly #1304
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
By using
Default(DEFAULT_MARKUP_MODE),rich_markup_modewould be atyper.models.DefaultPlaceholderobject and comparing it to other literal strings likeMARKUP_MODE_RICHwould fail. This resulted in flaky behaviour such as reported in #976, where Rich formatting worked fine when specifying it correctly, but the default value (with Rich installed) didn't result in the same behaviour.This PR fixes that by simply not using
Defaultfor this value - there's no real reason to use it anyway, as it's unimportant to the application whether it's a default or a user-set value.