Skip to content

Conversation

@rbubley
Copy link

@rbubley rbubley commented Jan 8, 2024

This eases an issue with Multiple Models (table=True model inheriting from table=False model), where input JSON uses aliases.

@rbubley rbubley marked this pull request as draft January 8, 2024 16:31
@rbubley rbubley marked this pull request as ready for review January 8, 2024 17:16
@DurandA
Copy link

DurandA commented Jan 8, 2024

Does this also fix broken field alias since SQLModel 0.0.14? Thanks.

@rbubley
Copy link
Author

rbubley commented Jan 9, 2024

Does this also fix broken field alias since SQLModel 0.0.14? Thanks.

Almost. In your example in #725 you would need secret_name: str = Field(validation_alias="secretName"), and it then works.

@svlandeg svlandeg self-assigned this Sep 17, 2025
@svlandeg
Copy link
Member

Hi @rbubley, thanks for the PR and apologies for the late follow-up!

I think this should be fully covered by the PR #1577 which is a bit more extensive/generic. As such, I think we can close this one. But thanks again!

@svlandeg svlandeg closed this Oct 21, 2025
@svlandeg svlandeg removed their assignment Oct 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6 participants