Skip to content

Conversation

@byrman
Copy link
Contributor

@byrman byrman commented Oct 8, 2022

A previous fix was incomplete as it did not cover this use case: #315 (comment).

@codecov
Copy link

codecov bot commented Oct 8, 2022

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ea79c47) 98.49% compared to head (2d6e7a1) 98.49%.
Report is 38 commits behind head on main.

❗ Current head 2d6e7a1 differs from pull request most recent head 512482c. Consider uploading reports for the commit 512482c to get more accurate results

Additional details and impacted files
@@ Coverage Diff @@ ## main #461 +/- ## ======================================= Coverage 98.49% 98.49% ======================================= Files 185 185 Lines 5856 5856 ======================================= Hits 5768 5768 Misses 88 88 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 8, 2022

@github-actions
Copy link
Contributor

github-actions bot commented Oct 9, 2022

@github-actions
Copy link
Contributor

github-actions bot commented Oct 9, 2022

@github-actions
Copy link
Contributor

@github-actions
Copy link
Contributor

@tiangolo
Copy link
Member

I was finally able to check it, the tests, etc. Thank you @byrman! This will be available in SQLModel 0.0.9 in the next hours. 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

2 participants