👷 Add Codecov to CI, Smokeshow/Cloudflare has been flaky lately #1303
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅ |
…(e.g. coverage.xml)
svlandeg added a commit to svlandeg/sqlmodel that referenced this pull request Feb 21, 2025
…ely (fastapi#1303)" This reverts commit 759220d.
svlandeg added a commit that referenced this pull request Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
👷 Add Codecov to CI, Smokeshow/Cloudflare has been flaky lately
This adds Codecov, but doesn't remove all the Smokeshow setup, so we can have both. I'll start enforcing Codecov, but we can see how flaky/slow both setups are more or less at the same time.