🐛 Avoid emitting undefined as a return value #82
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Consider an empty emitter function: ```ts @component class MyComponent { @emit public foo(): void {} } ``` We would expect this to emit a `'foo'` event with no arguments (since the return value is `undefined`). However, when testing with `@vue/test-utils`, we have to write: ```ts expect(component.emitted('foo')).to.eql([[undefined]]) ``` But it would be nicer - and more consistent with [`vue-property-decorator`][1] - if we instead called `$emit()` with no arguments in this case to be able to write: ```ts expect(component.emitted('foo')).to.eql([[]]) ``` [1]: https://github.com/kaorun343/vue-property-decorator/blob/e04872349bab357e6d08b01442f83abc9976eb50/src/decorators/Emit.ts#L22
alecgibson force-pushed the emit-undefined branch from 65d6849 to ef53aea Compare 
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Consider an empty emitter function:
We would expect this to emit a
'foo'event with no arguments (since the return value isundefined).However, when testing with
@vue/test-utils, we have to write:But it would be nicer - and more consistent with
vue-property-decorator- if we instead called$emit()with no arguments in this case to be able to write: