Skip to content

Conversation

@sophiebits
Copy link
Collaborator

Depends on facebook/react-devtools#23 to be useful.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super nit-picky, but I believe we use single quotes for 'undefined' everywhere else.

On another note, would it not make sense to always display the message (appended with for Chrome unless the global is defined), unless __react_devtools__ is defined, that way, people who prefer IE or FF are still made aware of it.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad. At KA we use double quotes so I get mixed up when switching.

My guess is users of other browsers would find that annoying.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea, we opted to just show it to people in the browser we support. When we get a FF extension (who wants to write it with me?), we'll show the message there too.

Otherwise, I think we should just market the extension more strongly on the site so that people with other browsers know that Chrome+extension is an option.

@sophiebits
Copy link
Collaborator Author

We're going to do this a different way.

@sophiebits sophiebits closed this Apr 7, 2014
@jeberly
Copy link

jeberly commented Jul 5, 2014

Is there any way to get around this problem atm?

@jordanstephens
Copy link

We're going to do this a different way.

@spicyj can you elaborate?

@waldreiter
Copy link
Contributor

I would suggest to remove the warning completely. There is no need to warn, since react works perfectly fine without the dev tools. The docs are the right place to tell people about them.

@zpao
Copy link
Member

zpao commented Jul 28, 2014

Logging is actually really helpful for "just in time" advertising - people open the devtools to debug something and see the message. It should go away if installed but it's not too terribly annoying right now so it hasn't been a priority.

@waldreiter
Copy link
Contributor

I guess without a little bit of spam this wouldn't be facebook. My way around it is a plugin for webpack. From my webpack.config.js:

new webpack.DefinePlugin({ 'console.debug': function(text){ if (text.indexOf('Download the React DevTools') !== 0) console.debug(text); } })
@pamelafox
Copy link

Can you reword it to "If you haven't already, download.." for now, if there's no way to detect its installation?
That way, I don't get all anxious that I haven't downloaded it when I actually have.

sophiebits added a commit to sophiebits/react that referenced this pull request Aug 4, 2014
@xpe
Copy link

xpe commented Sep 11, 2014

It isn't a "warning" if it always appears. Perhaps it would be better to remove the warning altogether? (That's what I'll do in my local copy.)

@EvHaus
Copy link

EvHaus commented Sep 22, 2014

Please consider removing the warning all together. It's very distracting to developers who monitor the console very closely.

@zpao
Copy link
Member

zpao commented Oct 15, 2014

For those not following along in master, this should be fixed now. Latest devtools + React v0.12 will be quiet if you already have the tools installed.

@sssahas
Copy link

sssahas commented Jan 1, 2015

I installed the latest extension few days back, it was working good, however, dont see the plugin anymore in devtools. When Ioad my app, I see this on the console " Download the React DevTools for a better development experience"

@gaearon
Copy link
Collaborator

gaearon commented Jan 1, 2015

@sahas- You're sure you're using React 0.12?

@sssahas
Copy link

sssahas commented Jan 1, 2015

@gaearon - it says Version: 0.12.1. I did pull it down from Chrome store..

@gaearon
Copy link
Collaborator

gaearon commented Jan 1, 2015

@sahas- I meant React's version, not extension's

@sssahas
Copy link

sssahas commented Jan 1, 2015

yep, here is what I see
// Version exists only in the open-source version of React, not in Facebook's
// internal version.
React.version = '0.12.2';
here is the gist: https://gist.github.com/sahas-/8cbd8c902803ced8d712

@sssahas
Copy link

sssahas commented Jan 3, 2015

any suggestions?

@gaearon
Copy link
Collaborator

gaearon commented Jan 3, 2015

Maybe you are opening a page via file:// protocol? In this case Chrome disables extensions unless you tick a special checkbox on Extensions page.

@sssahas
Copy link

sssahas commented Jan 3, 2015

Thanks. I'm running the app using mongoose web server locally. It did work a week ago but stopped for some reason.

@Tectract
Copy link

Tectract commented Oct 6, 2015

I find this message to be distracting to my dev process. How do I turn it off? I don't have react-devtools installed and I'm not interested in playing with it right now...

@OR13
Copy link

OR13 commented Feb 3, 2016

As an Angular dev consuming a 3rd party React plugin (Help Scout Beacons), I'd rather not see this message ever... I guess I will submit an issue to the plugin provider, as well.

Reminds me of: https://code.google.com/p/google-cast-sdk/issues/detail?id=309

Its not good advertising...

@maxfriedmann
Copy link

We're using https://www.npmjs.com/package/zombie for some headless ui testing and this message pops up all the time. We're having react components there (which are tested by JEST in a different step) as well but in that scenario we explicitly don't want to use the React DevTools.

I agree with @OR13, not a very good place for advertising...

> jasmine-node --test-dir tests/ui --coffee --matchall --autotest Watching for changes in tests/ui Download the React DevTools for a better development experience: https://fb.me/react-devtools .Download the React DevTools for a better development experience: https://fb.me/react-devtools . Finished in 0.622 seconds 2 tests, 4 assertions, 0 failures, 0 skipped tests/ui/homepage-spec.js was changed Download the React DevTools for a better development experience: https://fb.me/react-devtools .Download the React DevTools for a better development experience: https://fb.me/react-devtools . Finished in 0.618 seconds 2 tests, 4 assertions, 0 failures, 0 skipped tests/ui/homepage-spec.js was changed Download the React DevTools for a better development experience: https://fb.me/react-devtools .Download the React DevTools for a better development experience: https://fb.me/react-devtools . Finished in 0.619 seconds 2 tests, 4 assertions, 0 failures, 0 skipped 
@mikeesouth
Copy link

Seconded. How can we disable this warning? I'm using a library (auth0-lock) and that library is including React. I'm not using React myself and I have no interest in installing the React DevTools.

@newswim
Copy link

newswim commented Jan 4, 2017

Thirded.

@kyletaylored
Copy link

+1

I'm not even a React developer, and this message is incredibly distracting when working on my own project, but it's caused by some browser extension using React. If someone is using React and you want them to use DevTools, make it blatantly obvious in the docs instead of spamming every developer's console who isn't even using it.

@wbowers-coursera
Copy link

+1 still seeing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet