add RSC entrypoint for jsx-runtime #28217

gnoff · 2024-02-02T19:16:24Z

Adds a new entrypoint for the production jsx-runtime when using react-server condition. Currently the entrypoints are the same but in the future we will potentially change the implementation of the runtime in ways that can only be optimized for react-server constraints and we want to have the entrypoint already separated so environments using it will be pulling in the right version

…-server condition. Currently the entrypoints are the same but in the future we will potentially change the implementation of the runtime in ways that can only be optimized for react-server constraints and we want to have the entrypoint aleady separated so environments using it will be pulling in the right version

react-sizebot · 2024-02-02T19:20:09Z

Comparing: 2efa383...baf30f0

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name	+/-	Base	Current	+/- gzip	Base gzip	Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js	=	176.57 kB	176.57 kB	=	55.00 kB	55.00 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js	=	178.69 kB	178.69 kB	=	55.64 kB	55.64 kB
facebook-www/ReactDOM-prod.classic.js	=	591.32 kB	591.32 kB	=	104.34 kB	104.34 kB
facebook-www/ReactDOM-prod.modern.js	=	575.08 kB	575.08 kB	=	101.43 kB	101.43 kB
oss-experimental/react/cjs/react-jsx-runtime.react-server.development.js	+∞%	0.00 kB	47.15 kB	+∞%	0.00 kB	13.71 kB
oss-experimental/react/cjs/react-jsx-runtime.react-server.production.js	+∞%	0.00 kB	4.15 kB	+∞%	0.00 kB	1.85 kB
oss-experimental/react/cjs/react-jsx-runtime.react-server.production.min.js	+∞%	0.00 kB	0.92 kB	+∞%	0.00 kB	0.57 kB
oss-stable-semver/react/cjs/react-jsx-runtime.react-server.development.js	+∞%	0.00 kB	46.94 kB	+∞%	0.00 kB	13.68 kB
oss-stable-semver/react/cjs/react-jsx-runtime.react-server.production.js	+∞%	0.00 kB	4.15 kB	+∞%	0.00 kB	1.85 kB
oss-stable-semver/react/cjs/react-jsx-runtime.react-server.production.min.js	+∞%	0.00 kB	0.92 kB	+∞%	0.00 kB	0.57 kB
oss-stable/react/cjs/react-jsx-runtime.react-server.development.js	+∞%	0.00 kB	46.94 kB	+∞%	0.00 kB	13.68 kB
oss-stable/react/cjs/react-jsx-runtime.react-server.production.js	+∞%	0.00 kB	4.15 kB	+∞%	0.00 kB	1.85 kB
oss-stable/react/cjs/react-jsx-runtime.react-server.production.min.js	+∞%	0.00 kB	0.92 kB	+∞%	0.00 kB	0.57 kB
test_utils/ReactAllWarnings.js	Deleted	67.56 kB	0.00 kB	Deleted	16.59 kB	0.00 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show

Name	+/-	Base	Current	+/- gzip	Base gzip	Current gzip
oss-experimental/react/cjs/react-jsx-runtime.react-server.development.js	+∞%	0.00 kB	47.15 kB	+∞%	0.00 kB	13.71 kB
oss-experimental/react/cjs/react-jsx-runtime.react-server.production.js	+∞%	0.00 kB	4.15 kB	+∞%	0.00 kB	1.85 kB
oss-experimental/react/cjs/react-jsx-runtime.react-server.production.min.js	+∞%	0.00 kB	0.92 kB	+∞%	0.00 kB	0.57 kB
oss-stable-semver/react/cjs/react-jsx-runtime.react-server.development.js	+∞%	0.00 kB	46.94 kB	+∞%	0.00 kB	13.68 kB
oss-stable-semver/react/cjs/react-jsx-runtime.react-server.production.js	+∞%	0.00 kB	4.15 kB	+∞%	0.00 kB	1.85 kB
oss-stable-semver/react/cjs/react-jsx-runtime.react-server.production.min.js	+∞%	0.00 kB	0.92 kB	+∞%	0.00 kB	0.57 kB
oss-stable/react/cjs/react-jsx-runtime.react-server.development.js	+∞%	0.00 kB	46.94 kB	+∞%	0.00 kB	13.68 kB
oss-stable/react/cjs/react-jsx-runtime.react-server.production.js	+∞%	0.00 kB	4.15 kB	+∞%	0.00 kB	1.85 kB
oss-stable/react/cjs/react-jsx-runtime.react-server.production.min.js	+∞%	0.00 kB	0.92 kB	+∞%	0.00 kB	0.57 kB
facebook-react-native/react-test-renderer/cjs/ReactTestRenderer-prod.js	+0.22%	314.25 kB	314.94 kB	+0.19%	55.62 kB	55.72 kB
facebook-react-native/react-test-renderer/cjs/ReactTestRenderer-profiling.js	+0.21%	330.15 kB	330.84 kB	+0.15%	58.08 kB	58.17 kB
react-native/implementations/ReactFabric-profiling.js	=	341.80 kB	341.10 kB	=	60.00 kB	59.89 kB
test_utils/ReactAllWarnings.js	Deleted	67.56 kB	0.00 kB	Deleted	16.59 kB	0.00 kB

Generated by 🚫 dangerJS against baf30f0

Adds a new entrypoint for the production jsx-runtime when using react-server condition. Currently the entrypoints are the same but in the future we will potentially change the implementation of the runtime in ways that can only be optimized for react-server constraints and we want to have the entrypoint already separated so environments using it will be pulling in the right version DiffTrain build for [00f9acb](00f9acb)

Adds a new entrypoint for the production jsx-runtime when using react-server condition. Currently the entrypoints are the same but in the future we will potentially change the implementation of the runtime in ways that can only be optimized for react-server constraints and we want to have the entrypoint already separated so environments using it will be pulling in the right version

dai-shi · 2024-02-10T10:27:03Z

Not sure if this is the right place to comment, but fyi: wakujs/waku#467 (comment)

gaearon · 2024-02-11T00:24:01Z

Thanks for the report! Sent #28301

#28217 doesn't work without this since it's not included in the files list. See wakujs/waku#467 (comment). This should fix that.

Adds a new entrypoint for the production jsx-runtime when using react-server condition. Currently the entrypoints are the same but in the future we will potentially change the implementation of the runtime in ways that can only be optimized for react-server constraints and we want to have the entrypoint already separated so environments using it will be pulling in the right version

facebook#28217 doesn't work without this since it's not included in the files list. See wakujs/waku#467 (comment). This should fix that.

Adds a new entrypoint for the production jsx-runtime when using react-server condition. Currently the entrypoints are the same but in the future we will potentially change the implementation of the runtime in ways that can only be optimized for react-server constraints and we want to have the entrypoint already separated so environments using it will be pulling in the right version DiffTrain build for commit 00f9acb.

facebook/react#28217 doesn't work without this since it's not included in the files list. See wakujs/waku#467 (comment). This should fix that. DiffTrain build for commit facebook/react@269edb8.

gnoff requested a review from acdlite February 2, 2024 19:16

facebook-github-bot added CLA Signed React Core Team Opened by a member of the React Core Team labels Feb 2, 2024

gnoff requested a review from sebmarkbage February 2, 2024 19:24

acdlite approved these changes Feb 2, 2024

View reviewed changes

gnoff merged commit 00f9acb into facebook:main Feb 2, 2024

gnoff deleted the fork-jsx-runtime branch February 2, 2024 21:37

gnoff mentioned this pull request Feb 5, 2024

Update React from 60a927d04 to 2bc7d336a vercel/next.js#61522

Merged

gaearon mentioned this pull request Feb 11, 2024

Add jsx-runtime.react-server.js to file allowlist #28301

Merged

gaearon added a commit that referenced this pull request Feb 11, 2024

Add jsx-runtime.react-server.js to file allowlist (#28301)

269edb8

#28217 doesn't work without this since it's not included in the files list. See wakujs/waku#467 (comment). This should fix that.

ztanner mentioned this pull request Mar 19, 2024

(backport) Update React from 60a927d04 to 14898b6a9 vercel/next.js#63442

Closed

himself65 mentioned this pull request Apr 26, 2024

fix: add react-server condition for react/jsx-dev-runtime #28921

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

add RSC entrypoint for jsx-runtime #28217

add RSC entrypoint for jsx-runtime #28217

Uh oh!

gnoff commented Feb 2, 2024

react-sizebot commented Feb 2, 2024

dai-shi commented Feb 10, 2024

gaearon commented Feb 11, 2024

Labels

6 participants

add RSC entrypoint for jsx-runtime #28217

add RSC entrypoint for jsx-runtime #28217

Uh oh!

Conversation

gnoff commented Feb 2, 2024

react-sizebot commented Feb 2, 2024

Critical size changes

Significant size changes

dai-shi commented Feb 10, 2024

gaearon commented Feb 11, 2024

Labels

6 participants