- Notifications
You must be signed in to change notification settings - Fork 49.9k
Add a regression test for an infinite suspense + Fix #27703
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
8b08e3c to c6ffc00 Compare | Comparing: aec521a...f04d179 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) |
c6ffc00 to df70ebe Compare df70ebe to b663841 Compare | }, | ||
| ); | ||
| | ||
| // @gate enableLegacyCache |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can remove this, but probably need the enableRetryLaneExpiration.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
enableLegacyCache is needed to make the test pass, otherwise text cache in the test setup throws.
enableRetryLaneExpiration has VARIANT flag so it runs with both true and false, I think it's better to have it run both.
This is another place we special-case Retry lanes to opt them out of expiration. The reason is we rely on time slicing to unwrap uncached promises (i.e. async functions during render). Since that ability is still experimental, and enableRetryLaneExpiration is Meta-only, we can remove the special case when enableRetryLaneExpiration is on, for now.
40aa2c4 to 23e50e8 Compare Updates React from 2c338b16f to 0cdfef19b. ### React upstream changes - facebook/react#27821 - facebook/react#27820 - facebook/react#27818 - facebook/react#27819 - facebook/react#27817 - facebook/react#27703 - facebook/react#27796 - facebook/react#27811 - facebook/react#27804 - facebook/react#27807 - facebook/react#27805 - facebook/react#27792 - facebook/react#27788 - facebook/react#26852 - facebook/react#27790 - facebook/react#27786 - facebook/react#27785 - facebook/react#27783 - facebook/react#27784 - facebook/react#27769 - facebook/react#27766 - facebook/react#27701 - facebook/react#27732 - facebook/react#27740 - facebook/react#27767 - facebook/react#27768 - facebook/react#27765 - facebook/react#27759 - facebook/react#27579 - facebook/react#27709 - facebook/react#27734 - facebook/react#27739 - facebook/react#27717 - facebook/react#27583 - facebook/react#27713 Closes NEXT-1887
Updates React from 2c338b16f to 0cdfef19b. ### React upstream changes - facebook/react#27821 - facebook/react#27820 - facebook/react#27818 - facebook/react#27819 - facebook/react#27817 - facebook/react#27703 - facebook/react#27796 - facebook/react#27811 - facebook/react#27804 - facebook/react#27807 - facebook/react#27805 - facebook/react#27792 - facebook/react#27788 - facebook/react#26852 - facebook/react#27790 - facebook/react#27786 - facebook/react#27785 - facebook/react#27783 - facebook/react#27784 - facebook/react#27769 - facebook/react#27766 - facebook/react#27701 - facebook/react#27732 - facebook/react#27740 - facebook/react#27767 - facebook/react#27768 - facebook/react#27765 - facebook/react#27759 - facebook/react#27579 - facebook/react#27709 - facebook/react#27734 - facebook/react#27739 - facebook/react#27717 - facebook/react#27583 - facebook/react#27713 Closes NEXT-1887
Add a regression test for the [minimal repro](https://codesandbox.io/s/react-18-suspense-state-never-resolving-bug-hmlny5?file=/src/App.js) from @kassens And includes the fix from @acdlite: > This is another place we special-case Retry lanes to opt them out of expiration. The reason is we rely on time slicing to unwrap uncached promises (i.e. async functions during render). Since that ability is still experimental, and enableRetryLaneExpiration is Meta-only, we can remove the special case when enableRetryLaneExpiration is on, for now. --------- Co-authored-by: Andrew Clark <git@andrewclark.io>
Add a regression test for the minimal repro from @kassens
And includes the fix from @acdlite: