Add KeyboardEvent.code to synthetic event #18287
Conversation
| This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 223785a:
|
bl00mber force-pushed the bl00mber-patch-KeyboardEvent.code branch 5 times, most recently from 3cc717e to bbdec14 Compare 
bl00mber force-pushed the bl00mber-patch-KeyboardEvent.code branch from bbdec14 to ee40b3f Compare 
| const SyntheticKeyboardEvent = SyntheticUIEvent.extend({ | ||
| key: getEventKey, | ||
| code: function(event) { | ||
| if (event.type === 'keydown' || event.type === 'keyup') { |
There was a problem hiding this comment.
Can we just have code: null? Why does it need special handling?
There was a problem hiding this comment.
I assumed this structure had something with react internals or KeyboardEvent specification because lower on this interface similar blocks are placed. When keypress callback is executed without react, code is equal to output of keydown and keyup events. However, if it executed with react, the output will be null.
bl00mber force-pushed the bl00mber-patch-KeyboardEvent.code branch from 7b9772a to c4e3619 Compare | ); | ||
| expect(codeDown).toBe('KeyQ'); | ||
| expect(codeUp).toBe('KeyQ'); | ||
| expect(codePress).toBe(null); |
There was a problem hiding this comment.
What does the spec say it should be?
There was a problem hiding this comment.
The spec says it should be a valid code. For some reason onKeyPress callback do not called when dispatched without charCode! I added charCode and codePress initializes now.
bl00mber force-pushed the bl00mber-patch-KeyboardEvent.code branch from 6fd72ce to 223785a Compare 
4 participants
resolve #14102