feat: remove typescript flag and NODE_PATH support #8934
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
mrmckeb force-pushed the feature/remove-deprecations branch from 62a0707 to 53a6d06 Compare 
mrmckeb force-pushed the feature/remove-deprecations branch 2 times, most recently from aeb6808 to 5172040 Compare 
mrmckeb commented May 4, 2020
| templateJsonPath = path.join(templatePath, 'template.json'); | ||
| } else { | ||
| // TODO: Remove support for this in v4. | ||
| templateJsonPath = path.join(appPath, '.template.dependencies.json'); |
There was a problem hiding this comment.
This is legacy, and is not related to the templates feature we released.
It was never officially supported and wasn't documented, and was used for internal testing purposes previously.
mrmckeb requested review from amyrlam, ianschmitz, iansu and petetnt as code owners mrmckeb commented May 4, 2020
| const templatePackage = templateJson.package || {}; | ||
| | ||
| // TODO: Deprecate support for root-level `dependencies` and `scripts` in v4. | ||
| // TODO: Deprecate support for root-level `dependencies` and `scripts` in v5. |
There was a problem hiding this comment.
We didn't get a minor out with a warning for this, so we will leave it in for v4.
iansu approved these changes May 5, 2020
| @ianschmitz I'll leave this to you to merge if you think it's good to go - when you have some time ;) |
ianschmitz approved these changes May 5, 2020
| Looks like some of the builds are failing. |
mrmckeb force-pushed the feature/remove-deprecations branch from 3736525 to aa69a30 Compare rfreling pushed a commit to rfreling/create-react-app that referenced this pull request May 30, 2020
victor-travelperk pushed a commit to travelperk/create-react-app that referenced this pull request Jun 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Removes support for the
--typescriptinitialisation flag and theNODE_PATHwherebaseUrlfromjsconfigortsconfigcan be used instead.This also removes a number of other small deprecated features tagged with v4.