Widen eslint-config-react-app peer dependency versions #8892
+1 −1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
See facebook#7790 for a previous similar PR.
NMinhNguyen requested review from ianschmitz, iansu, mrmckeb and petetnt as code owners 
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
See #7790 for a previous similar PR.
I don't believe it is a breaking change to widen the peer dependency version, it merely lets people using the newer 3.x version of
eslint-plugin-react-hooksuse it with this ESLint config (e.g. if they're not usingreact-scripts).react-scriptswill continue installing^1.6.1as it did before.