Fix --use-pnp for Yarn 2 #8460
Merged
Fix --use-pnp for Yarn 2 #8460
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nickserv requested review from ianschmitz, iansu, mrmckeb and petetnt as code owners 
mrmckeb approved these changes Feb 29, 2020
There was a problem hiding this comment.
This makes sense, thanks @nickmccurdy. @ianschmitz can I get a second review on this one? Thanks!
ianschmitz approved these changes Apr 7, 2020
| hi guys, as we have 2 reviews already, is it possible to merge it? |
iansu approved these changes May 5, 2020
| Thanks! |
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
The
--use-pnpflag will break Yarn 2 because PnP has been enabled by default and the flag has been removed. This improves user experience by automatically ignoring the flag for Yarn 2, and explaining that it won't be needed in the future.I've tested this with Yarn 1 and it works normally, though Yarn 2 has a different installation linking system that I couldn't get to work with create-react-app locally.