Skip to content

Support templates in scoped packages #7991

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 18, 2019
Merged

Support templates in scoped packages #7991

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
21bfa40
Support scoped cra-template packages.
klasbj Nov 17, 2019
29e6858
Prefix the package name inside a scope.
klasbj Nov 17, 2019
e2eb7c8
Fix package name when package did not have a scope.
klasbj Nov 17, 2019
9aa94be
Fix lint and build error on node 8.
klasbj Nov 17, 2019
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 11 additions & 5 deletions packages/create-react-app/createReactApp.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -647,11 +647,17 @@ function getTemplateInstallPackage(template, originalDirectory) {
) {
// for tar.gz or alternative paths
templateToInstall = template;
} else if (template.startsWith(templateToInstall)) {
templateToInstall = template;
} else if (!template.startsWith(templateToInstall)) {
// Add prefix `cra-template` to non-prefixed templates.
templateToInstall += `-${template}`;
} else {
// Add prefix 'cra-template-' to non-prefixed templates, leaving any
// @scope/ intact.
const packageMatch = template.match(/^(@[^/]+\/)?(.+)$/);
const scope = packageMatch[1] || '';
const templateName = packageMatch[2];

const name = templateName.startsWith(templateToInstall)
? templateName
: `${templateToInstall}-${templateName}`;
templateToInstall = `${scope}${name}`;
}
}

Expand Down