Skip to content

Conversation

eanplatter
Copy link
Contributor

@vjeux my last PR is failing travis, had to move the fs-extra dependency.

@ghost ghost added the CLA Signed label Jul 22, 2016
@vjeux
Copy link
Contributor

vjeux commented Jul 22, 2016

Waiting for travis this time before merging :))

@eanplatter
Copy link
Contributor Author

Wise man :)

@eanplatter
Copy link
Contributor Author

I was able to reproduce locally, and the e2e test worked locally after this change. So my hopes are high!

@vjeux
Copy link
Contributor

vjeux commented Jul 22, 2016

Yeah, this change looks good.

@vjeux vjeux merged commit 9c31d4f into facebook:master Jul 22, 2016
@gaearon
Copy link
Contributor

gaearon commented Jul 22, 2016

❤️ e2e

nwolverson pushed a commit to nwolverson/create-react-app that referenced this pull request Jun 29, 2017
fix(typescriptTransform): Let tsc read the config instead of using 'require'
@lock lock bot locked and limited conversation to collaborators Jan 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
3 participants