Fix the E2E script #3888
Merged
Fix the E2E script #3888
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| Umm this breaks Windows (??) |
| This explains it: Git exists on the system so it lets us |
gaearon force-pushed the gaearon-patch-3 branch from 2a4b18c to ee90d7c Compare 
akstuhl pushed a commit to akstuhl/create-react-app that referenced this pull request Mar 15, 2018
* Fix the E2E script * Delete .git if committing failed
zmitry pushed a commit to zmitry/create-react-app that referenced this pull request Sep 30, 2018
* Fix the E2E script * Delete .git if committing failed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
It needed this commit because our git integration had a race condition. I fixed it in #3877 so now the commit ends up empty and fails. We can remove this now.