Upgrade fsevents to 1.1.2 #2550
Merged
+1 −1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This eliminates a `yarn` warning on OSX machines running Node.js 8. See here for details: fsevents/fsevents#170 You can see an example of the warning in the second screenshot in facebook#2422 (comment)
josephfrazier force-pushed the fsevents-1.1.2 branch from 8f96f7a to 8deb823 Compare 
| The AppVeyor failure appears to be unrelated, and it happened to another PR as well. |
| when using create-react-app I have the following issue, and I couldn't start the project: |
| Great, thanks for this @josephfrazier! |
| @abdellah-el-mennani if that error shown is all you see, it can be ignored as it is a warning and is an optional dependency. Windows does not support |
Merged
| Any ideas why this still doesn't fix CI for Node 8? |
romaindso pushed a commit to romaindso/create-react-app that referenced this pull request Jul 10, 2017
This eliminates a `yarn` warning on OSX machines running Node.js 8. See here for details: fsevents/fsevents#170 You can see an example of the warning in the second screenshot in facebook#2422 (comment)
wmonk referenced this pull request in wmonk/create-react-app-typescript Aug 7, 2017
This eliminates a `yarn` warning on OSX machines running Node.js 8. See here for details: fsevents/fsevents#170 You can see an example of the warning in the second screenshot in facebook/create-react-app#2422 (comment)
hysan added a commit to hysan/instructor-code-challenge that referenced this pull request Feb 22, 2018
This fixes the following error on macOS with regards to and fsevents@1.0.17 not being found when using Node.js 8+. See issues and pull requests: facebook/create-react-app#2613 facebook/create-react-app#2550 fsevents/fsevents#170 fsevents/fsevents#169. A minimum verison of v1.0.8 is required as the PR was pushed in that release: https://github.com/facebook/create-react-app/releases/tag/v1.0.8 Considering the targeted nature of the project, I figured that upgrading to the latest (v1.1.1) would be safe.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This eliminates a
yarnwarning on OSX machines running Node.js 8. Seehere for details: fsevents/fsevents#170
You can see an example of the warning in the second screenshot in
#2422 (comment)
I verified this by running:
npm run create-react-app my-app cd my-app yarn