Add Subresource Integrity support #1176
Conversation
| Have you verified it works? |
| Yes it does on my machine - I'm trying to figure out if I can write a test for that. |
| This is the result I'm getting on a production build.
|
| No worries about the test—we don't have anything other than smoke checks at the moment. |
| LGTM |
| Thank you! |
| That was fast! Thanks a lot, I'm glad I contributed. |
* master: (30 commits) Relax peerDependencies for ESLint preset (facebook#1191) Update Webpack to fix source map issues (facebook#1188) Update webpack prod config (facebook#1181) Chrome 'open tab' reuse an empty tab when possible (facebook#1165) Use file-loader for svgs (facebook#1180) Fix Babel issues in tests by applying the right transforms (facebook#1179) [babel-preset-react-app] Temporary fix missing babel plugins (facebook#1177) Add Subresource Integrity support (facebook#1176) Remove path module from webpack config on eject. (facebook#1175) Don't strip stack traces of evaluated webpack bundles (facebook#1050) Add deploy to Firebase CDN on template's README (Closes facebook#374) (facebook#1143) Update e2e.sh (facebook#1167) Document what npm build does and pushState (facebook#933) Fix minor typo/grammar (facebook#1099) Add "npm run build silently fails" to Troubleshooting (facebook#1168) Add testURL to jest config (facebook#1120) Make jsx-no-undef rule an error (facebook#1159) Update CHANGELOG.md Publish Update changelog for 0.8.1 ...
* Add Subresource Integrity support * Pin dependency
* Add Subresource Integrity support * Pin dependency
| Excuse me, how to use this? My final build doesn't contains SRI at all. What I'm doing wrong? In this page I can't find anything: https://github.com/facebookincubator/create-react-app/blob/master/packages/react-scripts/template/README.md |
| @johnunclesam As far as I remember, the support has been unfortunately reverted. |
| @XVincentX but why Vincent? Can we add it again today? |
| See #1231 for more details |
3 participants
This pull request will add to
create-react-appthe ability to inject into the final html page the integrity hashes required to take advantage of Subresource Integrity (when the browser supports it)