Skip to content

Add an explicit root to webpack.resolve so it searchs there first #1131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Add an explicit root to webpack.resolve so it searchs there first #1131

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
acbe8f5
Add an explicit root to webpack.resolve so it searchs there first
Dec 1, 2016
f3eedf0
Added comment and added to prod config
jimmyhmiller Dec 4, 2016
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions packages/react-scripts/config/webpack.config.dev.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,12 @@ module.exports = {
publicPath: publicPath
},
resolve: {
// This ensures that create-react-app's node_modules are first checked before
// other module locations (e.g. NODE_PATH). Without this, if NODE_PATH has
// the same module, webpack will use it before the dependency specified in our
// node modules.
// https://github.com/facebookincubator/create-react-app/issues/1023
root: paths.ownNodeModules,
// This allows you to set a fallback for where Webpack should look for modules.
// We read `NODE_PATH` environment variable in `paths.js` and pass paths here.
// We use `fallback` instead of `root` because we want `node_modules` to "win"
Expand Down
6 changes: 6 additions & 0 deletions packages/react-scripts/config/webpack.config.prod.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,12 @@ module.exports = {
publicPath: publicPath
},
resolve: {
// This ensures that create-react-app's node_modules are first checked before
// other module locations (e.g. NODE_PATH). Without this, if NODE_PATH has
// the same module, webpack will use it before the dependency specified in our
// node modules.
// https://github.com/facebookincubator/create-react-app/issues/1023
root: paths.ownNodeModules,
// This allows you to set a fallback for where Webpack should look for modules.
// We read `NODE_PATH` environment variable in `paths.js` and pass paths here.
// We use `fallback` instead of `root` because we want `node_modules` to "win"
Expand Down