Fix #3568: Pod upload file fails if file is directly in root path #3719
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
rohanKanojia force-pushed the pr/issue3568 branch from 756de1e to f08cad0 Compare 
sunix approved these changes Jan 10, 2022
… path Pod file upload seems be be creating invalid exec command for upload if the file is directly in root path e.g. `/cp.log`. We create parent directory of file by creating a substring based on last index of `/`. This returns an empty string for a string like `/cp.log`. Assume directory path to be `/` when directory is returned as empty string. Signed-off-by: Rohan Kumar <rohaan@redhat.com>
| Kudos, SonarCloud Quality Gate passed! |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Description
Fix #3568
Pod file upload seems be be creating invalid exec command for upload if
the file is directly in root path e.g.
/cp.log. We create parentdirectory of file by creating a substring based on last index of
/.This returns an empty string for a string like
/cp.log.Assume directory path to be
/when directory is returned as empty string.Signed-off-by: Rohan Kumar rohaan@redhat.com
Type of change
test, version modification, documentation, etc.)
Checklist