Skip to content

Conversation

@Phillip9587
Copy link
Member

I noticed that the current CI workflow in this repository could benefit from some updates. Specifically:

  1. Deprecation of Artifact Actions v3:

    • The actions/upload-artifact@v3 and actions/download-artifact@v3 actions are being deprecated as of November 30, 2024 (GitHub Deprecation Notice).
    • These actions should be updated to their latest versions to ensure continued functionality in the CI workflow.
    • CI Runs are currently failing like in PR chore(deps): update debug to ^4.4.0 #6313
  2. The Coverage setup could also be optimized:

    • Currently, the workflow uses the coverallsapp/github-action@master which points to v1 of this action. This v1 action uses node16 as runtime which is deprecated.
  3. Minimum token permissions for the GITHUB_TOKEN:

  4. lint step install only dev dependencies

@UlisesGascon
Copy link
Member

I will merge this PR as currently has a fix for our broken CI (example)

Screenshot from 2025-02-05 13-26-26

@UlisesGascon UlisesGascon merged commit a5cb681 into expressjs:master Feb 5, 2025
21 checks passed
@UlisesGascon
Copy link
Member

@Phillip9587 do you mind to port this to 4.x branch too? Seems like the CI is broken too (ref) :)

Phillip9587 added a commit to Phillip9587/express that referenced this pull request Feb 5, 2025
wesleytodd pushed a commit that referenced this pull request Feb 12, 2025
@bjohansebas bjohansebas mentioned this pull request Mar 15, 2025
@UlisesGascon UlisesGascon mentioned this pull request Mar 23, 2025
68 tasks
@wesleytodd wesleytodd mentioned this pull request Mar 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants