Skip to content

Conversation

wesleytodd
Copy link
Member

I missed that this was added in #5619 and would have opposed it if I had noticed. These badges are misleading in too many cases to make it worth including. Having seen some of the most wild projects and the impact of install time, I can confidently say that publishing more versions (aka the packument gets larger) is much worse of a problem than all but the most absurd cases of tarball size.

Anyway, it came up here so I thought I would open this PR to discuss.

Copy link
Member

@sheplu sheplu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I agree with you here, but I think this should even be a bit more drastic - we should have another readme used in the package.json
there is other assets that could be removed but I think we can have a side discussion about that

Copy link
Member

@UlisesGascon UlisesGascon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am neutral to this change 👍

Copy link
Member

@bjohansebas bjohansebas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wesleytodd wesleytodd merged commit 4f952a9 into master Jan 11, 2025
2 checks passed
@wesleytodd wesleytodd deleted the remove-size-badge branch February 14, 2025 16:03
@bjohansebas bjohansebas mentioned this pull request Mar 15, 2025
@UlisesGascon UlisesGascon mentioned this pull request Mar 23, 2025
68 tasks
@wesleytodd wesleytodd mentioned this pull request Mar 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6 participants