deps: upgrade supertest #6112
deps: upgrade supertest #6112
Conversation
| There is already a version 7. |
| @bjohansebas I was trying to target 7.0.0, seems like we will need to some work, based on the CI results |
UlisesGascon left a comment
UlisesGascon left a comment There was a problem hiding this comment.
LGTM! 6.3.4 is stable in the CI
| "nyc": "15.1.0", | ||
| "pbkdf2-password": "1.2.1", | ||
| "supertest": "6.3.0", | ||
| "supertest": "6.3.4", |
There was a problem hiding this comment.
Can we just unpin this (^)? I thought we agreed to just unpin all these as we touched them?
sheplu left a comment
sheplu left a comment There was a problem hiding this comment.
LGTM but as @wesleytodd said can we ^ the deps but also maybe not update them all one by one
fix(deps): mocha@^10.7.3 (closes #6121) fix(deps): marked@^15.0.3 (closes #6120) fix(deps): express-session@^1.18.1 (closes #6119) fix(deps): ejs@^3.1.10 (closes #6117) fix(deps): content-type@^1.0.5 (closes #6115) fix(deps): connect-redis@^8.0.1 (closes #6114) fix(deps): supertest@^7.0.0 (closes #6112)
fix(deps): mocha@^10.7.3 (closes #6121) fix(deps): marked@^15.0.3 (closes #6120) fix(deps): express-session@^1.18.1 (closes #6119) fix(deps): ejs@^3.1.10 (closes #6117) fix(deps): content-type@^1.0.5 (closes #6115) fix(deps): connect-redis@^8.0.1 (closes #6114) fix(deps): supertest@^6.3.4 (closes #6112)
| I am nearly positive I tried this update and hit the same error a few months ago. I searched but couldnt find the pr/issue. IIRC there is a bug in newer versions of In the new PR I pinned it back to the 6 range. |
6 participants
Related: #6103 (comment)