✅ add discarded middleware test #5819
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
wesleytodd reviewed Sep 10, 2024
wesleytodd approved these changes Sep 10, 2024
| Lets not merge anything more to |
UlisesGascon approved these changes Sep 10, 2024
| condition meet, I will merge the PR |
Closed
Merged
This was referenced Aug 15, 2025
This was referenced Aug 24, 2025
Jayx239 reviewed Sep 24, 2025
| .expect(200, 'yee', function(err, res) { | ||
| if (err) return done(err); | ||
| | ||
| router = new express.Router(); |
There was a problem hiding this comment.
I don't want to replace the router, I want to completely remove it.
| }); | ||
| | ||
| app.use(function (req, res, next) { | ||
| return router.handle(req, res, next); |
There was a problem hiding this comment.
To demonstrate the issue I am trying to address, replace
return router.handle(req, res, next);
with
console.log('I want to remove this'); return router.handle(req, res, next);
Is there a mechanism in this case to remove the console.log(...)?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
No description provided.