Skip to content

Conversation

@rritik772
Copy link

@rritik772 rritik772 commented Jul 11, 2024

[X] Ran tests
[X] Ran linter

Related #5714

Context: #5746 (comment)

Solution to: #5748

[X] Ran tests [X] Ran linter Related #5714 Context: #5746 (comment)
Copy link
Member

@UlisesGascon UlisesGascon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rritik772 for re-create the PR! 👍

Note: this pr depends on #5595 as we target Node@18 for v5.

@wesleytodd
Copy link
Member

Hey, really sorry about this. But as I was prepping to merge this I see we already merged #5829 which addressed this. This is a good reminder that we need to look for existing PRs and keep up on them better. We will try to do better about it in the future.

@wesleytodd wesleytodd closed this Aug 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3 participants