Fix favicon-related bug in cookie-sessions example #5414
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
dougwilson force-pushed the fix-bug-in-cookie-sessions-example branch from 37d2647 to 0e3ab6e Compare 
dougwilson approved these changes Feb 20, 2024
Merged
This was referenced Mar 26, 2024
This was referenced May 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Added the check for /favicon request in " count" middleware. Without this check, a request to /favicon that is made by most browsers will also increment the counter. This will lead to unwanted behaviour when a reload of a page will increment the counter for 2 instead of 1.
