use random port in test so it won't fail on already listening

[rluvaton]

In my machine, the docker desktop is using port 9999, so replacing it to 0 so it won't fail...

$ lsof -i:9999 COMMAND PID USER FD TYPE DEVICE SIZE/OFF NODE NAME com.docke 1752 myuser 295u IPv6 0x83cfbdc03dd8f0bf 0t0 TCP *:distinct (LISTEN) $ ps aux | grep 1752 myuser 1752 0.8 0.1 409650768 83072 ?? S 12:26AM 0:53.99 /Applications/Docker.app/Contents/MacOS/com.docker.backend -watchdog -native-api

[LinusU]

LGTM 👍

[dougwilson]

I think this is the only test that given a specific port is actually listens on that, but the test never asserts it, so probably fine to make it 0. We probably should add a test that given port x it actually listenes on port x somewhere though.

[rluvaton]

Any blocker from merging this?

[dougwilson]

Sorry @rluvaton no, I had just left a general comment, not a review change request. I will get it merged shortly, just wanted to give it at least like 24-48 hours for comments and stuff.

[rluvaton]

@dougwilson I updated with the requested test, can you re-review?

[krzysdz]

Your new tests will fail, because older Node.js versions don't support Promises.

[rluvaton]

Your new tests will fail, because older Node.js versions don't support Promises.

thanks, removed the use of Promises 😢

[rluvaton]

For some reason, it looked like the appveyor failed for unrelated reason

[rluvaton]

Any thoughts or maybe a rerun so we can merge this

[rluvaton]

Ping