Update path-to-regexp to 1.0.3 #2530
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Because of api changes, some tests had be updated. Backwards incampatible changes are: - Regular expressions have to be wrapped by parentheses -> /users/(\\d+) - standalone asterisk must be written as expression -> /(.*) Benefits: - Match one or more parameters -> /templates/:template+ - Match zero or more parameters -> /files/:path* - Optional parameters -> :foo/:bar?
The test description did not match the contained expectation.
| Just FYI, the latest version is currently |
| Oh, totally forgotten this PR… |
| Unfortunately path-to-regexp 0.1.7 is kinda buggy when using empty params. Latest version works good though. |
| @davebaol It can't be merged until 5.0 of Express.js. |
Closed
This was referenced Jan 17, 2019
| Closing this because it has been superseded by pillarjs/router#42 |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
I updated
path-to-regexpto the latest version. Because this will break slightly backwards compatibility, I would suggest to do this update for the upcoming major release. Major changes are the following:/users/(\\d+)/(.*)/templates/:template+/files/:path*:foo/:bar?