Skip to content

Update QaSchemaIT using TestKit [ECR-3054] #899

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dmitry-timofeev merged 2 commits into from
May 23, 2019
Merged

Update QaSchemaIT using TestKit [ECR-3054] #899

dmitry-timofeev merged 2 commits into from
May 23, 2019

Conversation

@MakarovS
Copy link
Contributor

@MakarovS MakarovS commented May 21, 2019 •
edited
Loading

Overview

Update QaSchemaIT using TestKit.

See: https://jira.bf.local/browse/ECR-3054

Definition of Done

  • There are no TODOs left in the code
  • Change is covered by automated tests
  • The coding guidelines are followed
  • Public API has Javadoc
  • Method preconditions are checked and documented in the Javadoc of the method
  • Changelog is updated if needed (in case of notable or breaking changes)
  • The continuous integration build passes
@MakarovS MakarovS requested a review from dmitry-timofeev May 21, 2019 05:13
@coveralls
Copy link

coveralls commented May 21, 2019

Coverage Status

Coverage remained the same at 86.259% when pulling dd014b1 on ECR-3054-QA into 16087f8 on master.
bullet-tooth
bullet-tooth approved these changes May 21, 2019
View reviewed changes
...a-binding/qa-service/src/test/java/com/exonum/binding/qaservice/QaSchemaIntegrationTest.java
Snapshot snapshot = db.createSnapshot(cleaner);
QaSchema schema = new QaSchema(snapshot);
void getStateHashesEmptyDb() {
try (TestKit testKit = TestKit.forService(QaServiceModule.class)) {
Copy link
Contributor

@bullet-tooth bullet-tooth May 21, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have a task for implementing testkit extension for junit? 🙃
Copy link
Contributor

@dmitry-timofeev dmitry-timofeev May 21, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't you been to the grooming?
Copy link
Contributor Author

@MakarovS MakarovS May 22, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have a task for implementing testkit extension for junit? 🙃

Yes, we do :) ECR-3076 I believe
dmitry-timofeev
dmitry-timofeev reviewed May 21, 2019
View reviewed changes
Copy link
Contributor

@dmitry-timofeev dmitry-timofeev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall we use testkit here as we don't rely on any of its operations? It helps, however, to get rid of the Cleaner instantiation. Maybe, to make MemoryDb easier to use, we shall add withSnapshot to it, shan't we?
@MakarovS
Copy link
Contributor Author

MakarovS commented May 22, 2019

Shall we use testkit here as we don't rely on any of its operations? It helps, however, to get rid of the Cleaner instantiation. Maybe, to make MemoryDb easier to use, we shall add withSnapshot to it, shan't we?

I prefer using TestKit for consistency and replace MemoryDb with it when possible.
@dmitry-timofeev
Copy link
Contributor

dmitry-timofeev commented May 23, 2019

🙆‍♂️ , though MemoryDb is also good as its use doesn't violate local consistency 🙃
@dmitry-timofeev dmitry-timofeev merged commit b616eb6 into master May 23, 2019
dmitry-timofeev added a commit that referenced this pull request May 23, 2019
@dmitry-timofeev
Update QaSchema IT to use TestKit [ECR-3054] (#899)
0f784e4 
Use testkit instead of memoryDb to access the database state.
dmitry-timofeev pushed a commit that referenced this pull request May 23, 2019
@MakarovS @dmitry-timofeev
Update QaSchema IT to use TestKit [ECR-3054] (#899)
fae6873 
Use testkit instead of memoryDb to access the database state.
@MakarovS MakarovS deleted the ECR-3054-QA branch May 24, 2019 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

5 participants

@MakarovS @coveralls @dmitry-timofeev @bullet-tooth