Skip to content

[ECR-2867] Fixed links to the new repo name #696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
bullet-tooth wants to merge 3 commits into
base: master
Choose a base branch
from
Open

[ECR-2867] Fixed links to the new repo name #696

bullet-tooth wants to merge 3 commits into from

Conversation

@bullet-tooth
Copy link
Contributor

@bullet-tooth bullet-tooth commented Feb 11, 2019

Overview

See: https://jira.bf.local/browse/ECR-2867
Should be double checked and merged after the repo renaming.

Definition of Done

  • There are no TODOs left in the code
  • Change is covered by automated tests
  • The coding guidelines are followed
  • Public API has Javadoc
  • Method preconditions are checked and documented in the Javadoc of the method
  • Changelog is updated if needed (in case of notable or breaking changes)
  • The continuous integration build passes
bullet-tooth
bullet-tooth commented Feb 11, 2019
View reviewed changes
README.md

[![Build Status](https://img.shields.io/travis/exonum/exonum-java-binding/master.svg)](https://travis-ci.com/exonum/exonum-java-binding)
[![Coverage Status](https://coveralls.io/repos/github/exonum/exonum-java-binding/badge.svg?branch=master)](https://coveralls.io/github/exonum/exonum-java-binding?branch=master)
[![Build Status](https://img.shields.io/travis/exonum/exonum-java/master.svg)](https://travis-ci.com/exonum/exonum-java)
Copy link
Contributor Author

@bullet-tooth bullet-tooth Feb 11, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be additionally checked
@bullet-tooth bullet-tooth mentioned this pull request Feb 11, 2019
Closed
7 tasks
@coveralls
Copy link

coveralls commented Feb 11, 2019 •
edited
Loading

Coverage Status

Coverage remained the same at 85.438% when pulling 3dea2f1 on ecr-2867-1 into 750cca1 on master.
@bullet-tooth bullet-tooth added experimental ⚖️ Experimental PRs usually shall not be merged — they show some approach to get feedback from the team do not merge ⛔️ and removed experimental ⚖️ Experimental PRs usually shall not be merged — they show some approach to get feedback from the team labels Feb 15, 2019
@bullet-tooth bullet-tooth changed the title DO NOT MERGE [New project structure] [ECR-2867] Fixed links to the new repo name [New project structure] [ECR-2867] Fixed links to the new repo name Feb 15, 2019
@bullet-tooth bullet-tooth changed the title [New project structure] [ECR-2867] Fixed links to the new repo name [ECR-2867] Fixed links to the new repo name Feb 15, 2019
@vitvakatu vitvakatu removed their request for review August 16, 2019 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do not merge ⛔️

5 participants

@bullet-tooth @coveralls @skletsun @MakarovS