Error-prone compiler enabled. [ECR-1746] #564
Conversation
exonum-java-testing/pom.xml Outdated
| <plugin> | ||
| <groupId>org.apache.maven.plugins</groupId> | ||
| <artifactId>maven-compiler-plugin</artifactId> | ||
| <configuration> |
There was a problem hiding this comment.
Why can't this configuration be inherited from the parent POM?
There was a problem hiding this comment.
It can. But if we make configuration inheritance :
mvn clean install - will work with error-prone
mvn clean install -pl :exonum-java-binding-common - won't work with error-prone
Do we need it separately for submodules ?
There was a problem hiding this comment.
Got it , need to specify combine.children="append" for correct configuration group.
exonum-java-testing/pom.xml Outdated
| @@ -1,5 +1,7 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
| <project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd"> | |||
| <project xmlns="http://maven.apache.org/POM/4.0.0" | |||
There was a problem hiding this comment.
mvn tidy:pom will help :)
dmitry-timofeev added the work-in-progress 👷♂️ 
| Please update |
| @bullet-tooth Error Prone is licensed under Apache license https://github.com/google/error-prone/blob/master/COPYING we already have it in LICENSES-THIRD-PARTY.TXT |
| @DENMROOT yes, it is. But there is a list of third parties governed under Apache 2.0 that should be extended with the new component |
Overview
Error-prone compiler enabled. POM files updated. AutoValue auto generated classes fixed.
See: https://jira.bf.local/browse/ECR-1746
Definition of Done