minor refactoring and cleanup of cryptocurrency demo #439
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
KateNegrienko approved these changes Aug 27, 2018
dmitry-timofeev suggested changes Aug 28, 2018
| | ||
| // initialize protobuf and add defined schema to protobuf root | ||
| const root = new Root() | ||
| root.define('CreateTransactionProtobuf').add(CreateTransactionProtobuf) |
Contributor
There was a problem hiding this comment.
Does it make sense to re-define these types each time we send a transaction?
| "big-integer": "^1.6.32", | ||
| "bootstrap": "^4.0.0", | ||
| "exonum-client": "^0.10.2", | ||
| "exonum-client": "^0.12.4", |
Contributor
There was a problem hiding this comment.
Just to double-check: this version does not use separated messages, does it?
| | ||
| transfer(keyPair, receiver, amountToTransfer, seed) { | ||
| | ||
| // define schema for transaction with protobuf |
Contributor
There was a problem hiding this comment.
I'd consider splitting this and the previous functions into smaller ones to ease reading, and avoid code duplication, as they've become rather long. E.g.:
def transferTx: createTransferTx(<parameters>) submitTransaction(id, body) 
bullet-tooth approved these changes Aug 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Overview
Please describe your changes here and list any open questions you might have.
See: https://jira.bf.local/browse/XYZ
Definition of Done