Skip to content

Dedicated branch for async migrations #1558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
bullet-tooth wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Dedicated branch for async migrations #1558

bullet-tooth wants to merge 9 commits into from

Conversation

@bullet-tooth
Copy link
Contributor

@bullet-tooth bullet-tooth commented May 25, 2020

Overview

Definition of Done

  • There are no TODOs left in the code
  • Change is covered by automated tests
  • The coding guidelines are followed
  • Public API has Javadoc
  • Method preconditions are checked and documented in the Javadoc of the method
  • Changelog is updated if needed (in case of notable or breaking changes)
  • The continuous integration build passes
@bullet-tooth bullet-tooth added the work-in-progress 👷‍♂️ Do not expect reviewers to provide any feedback on WIP PRs — please ask for it explicitly! label May 25, 2020
@coveralls
Copy link

coveralls commented May 25, 2020 •
edited
Loading

Coverage Status

Coverage increased (+0.2%) to 85.148% when pulling d0eda55 on async-migrations into 00e96da on master.
@bullet-tooth
fix rust improts
a608f6e
@bullet-tooth
[ECR-4409] Add migration scripts loading (#1557)
d0dc601 
* [ECR-4409] Add migration scripts loading * Allow having package-private service modules and migration scripts
@bullet-tooth
[ECR-4410] Add migration scripts lookup in Java services runtime (#1560)
9256669 
* scripts lookup in the service runtime * Use TempDir
@bullet-tooth
Add abstract migration script to base on (#1561)
8cf9db7 
* Add abstract migration script to base on
@bullet-tooth bullet-tooth mentioned this pull request Jun 4, 2020
Merged
@bullet-tooth
Merge branch 'master' into async-migrations
cf92a37 
# Conflicts: #	exonum-java-binding/core/src/main/java/com/exonum/binding/core/service/migration/MigrationScript.java
@bullet-tooth
minor
824896d
@bullet-tooth
Merge branch 'master' into async-migrations
31fd548
@bullet-tooth
Merge branch 'master' into async-migrations
d0eda55
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 12, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 1 Code Smell

96.1% 96.1% Coverage
0.0% 0.0% Duplication
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

work-in-progress 👷‍♂️ Do not expect reviewers to provide any feedback on WIP PRs — please ask for it explicitly!

3 participants

@bullet-tooth @coveralls