Skip to content

Enable the native ITs #1278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
dmitry-timofeev wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Enable the native ITs #1278

dmitry-timofeev wants to merge 1 commit into from

Conversation

@dmitry-timofeev
Copy link
Contributor

@dmitry-timofeev dmitry-timofeev commented Dec 9, 2019

Overview

Definition of Done

  • There are no TODOs left in the code
  • Change is covered by automated tests
  • The coding guidelines are followed
  • Public API has Javadoc
  • Method preconditions are checked and documented in the Javadoc of the method
  • Changelog is updated if needed (in case of notable or breaking changes)
  • The continuous integration build passes
@dmitry-timofeev dmitry-timofeev added the experimental ⚖️ Experimental PRs usually shall not be merged — they show some approach to get feedback from the team label Dec 9, 2019
@dmitry-timofeev
Copy link
Contributor Author

dmitry-timofeev commented Dec 9, 2019

thread 'concurrent_cache_read' panicked at 'Can't open classpath.txt: Os { code: 2, kind: NotFound, message: "No such file or directory" }', src/libcore/result.rs:999:5
@dmitry-timofeev
Copy link
Contributor Author

dmitry-timofeev commented Dec 10, 2019

@vitvakatu Would it make sense to update these tests (which one can be enabled already?) by changing the classpath in use to something else (e.g., the app classpath)?
@vitvakatu
Copy link
Contributor

vitvakatu commented Dec 11, 2019

Yep, I've had these changes somewhere...
I'd look into it
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

experimental ⚖️ Experimental PRs usually shall not be merged — they show some approach to get feedback from the team

2 participants

@dmitry-timofeev @vitvakatu